Improve gcov coverage reporting logic (and other minor changes) #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Update the top-level `README.md` with better descriptions of published Draco components. Also Update the copyright block and author list to reflect changes introduced with the release of Draco-7_5_0. + In `compilerEnv.cmake`, update logic related to how the `covrep` target is created by allowing client projects to append to `CODE_COVERAGE_IGNORE_REGEX`. Also use the new `block_indent` cmake function to pring this value when generating a build tree with `CODE_COVERAGE=ON`. + In `string_manip.cmake` provide a new cmake function `block_indent` to make it easier to print formatted information when configuring a project. + Update `vendor_libraries.cmake`, to ensure that Draco's code coverage setup is called during project configuration. Also ensure that we search for the CUDA compiler. + Only parse ds++ if the clang-tidy static analyzer is enabled. + Minor cleanup in `StackTrace` and associated unit test.
KineticTheory
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #766 +/- ##
=======================================
Coverage 94.0% 94.0%
=======================================
Files 367 367
Lines 17230 17230
=======================================
Hits 16198 16198
Misses 1032 1032 |
|
@alexrlongne This is ready for review. |
alexrlongne
approved these changes
Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
covrepmake target didn't work quite right for client projects.Description of changes
README.mdwith better descriptions of published Draco components. Also Update the copyright block and author list to reflect changes introduced with the release of Draco-7_5_0.compilerEnv.cmake, update logic related to how thecovreptarget is created by allowing client projects to append toCODE_COVERAGE_IGNORE_REGEX. Also use the newblock_indentcmake function to pring this value when generating a build tree withCODE_COVERAGE=ON.string_manip.cmakeprovide a new cmake functionblock_indentto make it easier to print formatted information when configuring a project.vendor_libraries.cmake, to ensure that Draco's code coverage setup is called during project configuration. Also ensure that we search for the CUDA compiler.StackTraceand associated unit test.Status